feat(Layout): integrated ErrorLogger handler global exception #6119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Reviewer's GuideIntegrates a global ErrorLogger into the main layout and root components by adding configuration parameters, injecting options, and wrapping content in an ErrorLogger component to capture and display exceptions. Sequence Diagram for Global Exception HandlingsequenceDiagram
participant C as Component
participant EL as ErrorLogger
participant OHEA as OnErrorHandleAsync (optional)
participant TS as ToastService (optional)
Note over C, EL: Content rendering within Layout/BootstrapBlazorRoot
C ->> C: Operation leads to exception
activate C
C --x EL: Exception Occurs
deactivate C
activate EL
EL ->> EL: Catches Exception
alt Custom Error Handling
EL ->> OHEA: OnErrorHandleAsync(logger, exception)
activate OHEA
OHEA -->> EL: Returns
deactivate OHEA
end
alt Show Toast (if _showToast is true)
EL ->> TS: DisplayErrorToast(ErrorLoggerToastTitle)
activate TS
TS -->> EL: Toast Displayed
deactivate TS
end
deactivate EL
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6119 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 703 703
Lines 31024 31048 +24
Branches 4387 4391 +4
=========================================
+ Hits 31024 31048 +24 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey @ArgoZhang - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This reverts commit 945c952.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #6118
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Integrate a global ErrorLogger component into the Layout and root components to capture unhandled exceptions, display configurable toasts, and allow custom handling callbacks.
New Features:
Enhancements: